Dan Kenigsberg has submitted this change and it was merged. Change subject: Introducing configurator package in vdsm-tool ......................................................................
Introducing configurator package in vdsm-tool This package union libvirt and sanlock configuration operations for now. The package defines ModuleConfigure interface and API for modules configuration tool. The format for the configure command is modified to: vdsm-tool configure --module libvirt --force This module also provides is-configured and validate-config verbs with the same syntax. --force flag means the configure flow will stop all related services if needed. Without force, if one of the related services is running, the configure will fail. For reuse and easier additional configurers for other services, all the developer needs to add is an object that inherit ModuleConfigure and implements the interface for test, dry and configure, then adding the class to configurers. Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/20100 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M debian/vdsm-python.install M init/systemd/systemd-vdsmd.in M init/sysvinit/vdsmd.init.in M init/vdsmd_init_common.sh.in M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/configurator.py D lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/libvirt_configure.sh.in D lib/vdsm/tool/sanlock.py M vdsm.spec.in 10 files changed, 316 insertions(+), 218 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
