Eduardo has posted comments on this change.
Change subject: remove irs_enable configuration attribute
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
....................................................
File vdsm/clientIF.py
Line 247: while self._enabled:
Line 248: time.sleep(3)
Line 249:
Line 250: def _initIRS(self):
Line 251: self.irs = None
Can this be removed? If not, it should be under the except clause.
Line 252: try:
Line 253: self.irs = Dispatcher(HSM())
Line 254: except:
Line 255: self.log.error("Error initializing IRS", exc_info=True)
Line 250: def _initIRS(self):
Line 251: self.irs = None
Line 252: try:
Line 253: self.irs = Dispatcher(HSM())
Line 254: except:
I would like a narrow except only because you are touching it, but...
Line 255: self.log.error("Error initializing IRS", exc_info=True)
Line 256: else:
Line 257:
self.irs.registerDomainStateChangeCallback(self.contEIOVms)
Line 258:
--
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
