Sergey Gotliv has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Did you try to use VDSM that way:
# vdsClient 0 connectStorageServer 3 98da1408-948d-4cab-9a8b-418914be9f07 \
connection=vm-rhsrv1.in1.bytenix.com,iqn=iqn.1994-05.com.redhat:ovirt1,portal=1,id=6cec6a56-8e1b-41bd-ac9d-c3866124389a,port=3260,initiatorName=ovirtmgmt
where initiatorName is the iface you want to use?
I am not convinced at this moment that we need to change something in VDSM in
order to achieve the goal described in that RFE.
Let's dusscuss.
....................................................
File vdsm/storage/hsm.py
Line 149: if not ifaceName:
Line 150: ifaces = config.get('irs', 'iscsi_default_ifaces').split(',')
Line 151: if ifaces and 'iser' not in ifaces:
Line 152: return iscsi.IscsiInterface(ifaces)
Line 153: else:
This code is probably not working, right?
Line 154: return iscsi.IscsiInterface(['default'])
Line 155:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
....................................................
File vdsm/storage/iscsiadm.py
Line 228: raise IscsiDiscoverdbError(rc, out, err)
Line 229:
Line 230:
Line 231: def node_new(iface, portal, targetName):
Line 232: for i in iface:
This method should receive exactly one interface, if you want to call it with
multiple interfaces, please, call this method in the loop in the caller method.
Same is true for all changes in that module.
Line 233: if not iface_exists(i):
Line 234: iface_new(i)
Line 235:
Line 236: rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I",
i, "-p",
--
To view, visit http://gerrit.ovirt.org/21189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I488c0a1401606ac40a5ee4ef3d816f53b1d22785
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
