Hello Antoni Segura Puimedon, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21196
to review the following change.
Change subject: pep8: Fix indentation to comply with pep8 1.3.3
......................................................................
pep8: Fix indentation to comply with pep8 1.3.3
Commit 2c9f0d66db7795 introduced a pep8 indentation regression, breaking
the build on RHEL using vdsm provided pep8. This patch fixes the
indentation by breaking long statement to multiple lines.
Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415
Relates-To: https://bugzilla.redhat.com/1022975
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/21055
Reviewed-by: Antoni Segura Puimedon <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/21196/1
diff --git a/vdsm/storage/imageRepository/formatConverter.py
b/vdsm/storage/imageRepository/formatConverter.py
index 441f484..c701163 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -276,8 +276,8 @@
for volUUID in imgVolumes:
try:
- v3ResetMetaVolSize( # BZ#811880
- domain.produceVolume(imgUUID, volUUID))
+ vol = domain.produceVolume(imgUUID, volUUID)
+ v3ResetMetaVolSize(vol) # BZ#811880
except qemuImg.QImgError:
log.error("It is not possible to read the volume %s "
"using qemu-img, the content looks damaged",
--
To view, visit http://gerrit.ovirt.org/21196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
