Yaniv Bronhaim has posted comments on this change. Change subject: tests: Add simple mocking library ......................................................................
Patch Set 1: (1 comment) .................................................... Commit Message Line 5: CommitDate: 2013-11-12 11:11:04 +0200 Line 6: Line 7: tests: Add simple mocking library Line 8: Line 9: New mock module provides a MockCallable, useful for mocking functions sounds like you can improve tests/monkeypatch.py instead of adding new style. can you check that out please? it also contains monkeypatchTests.py, so I wonder if we might duplicate something here.. Line 10: and other callables required for testing stuff that needs special Line 11: environment for running. Line 12: Line 13: MockCallable is using the record and play aprroach; After a mock is -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
