Nir Soffer has posted comments on this change.
Change subject: hsm: Do not hide errors when checking device visibility
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 2031: res = (os.stat('/dev/mapper/' + guid).st_mode &
Line 2032: stat.S_IRUSR != 0)
Line 2033: except OSError as e:
Line 2034: if e.errno != errno.NOENT:
Line 2035: raise
I don't know, but if it cannot handle exceptions in @public commands then you
should go and fix it now :-)
Line 2036: res = False
Line 2037: return res
Line 2038:
Line 2039: visibility = [_isVisible(guid) for guid in guids]
--
To view, visit http://gerrit.ovirt.org/21211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
