Dan Kenigsberg has posted comments on this change. Change subject: vm: prevent faulty volume extensions ......................................................................
Patch Set 3: (1 comment) .................................................... File vdsm/vm.py Line 2291: Line 2292: # Since the check based on nextPhysSize is extremly risky (it Line 2293: # may result in the VM being paused) we can't use the regular Line 2294: # getNextVolumeSize call as it relies on a cached value of the Line 2295: # drive apparentsize. I do not understand this comment.. If getNextVolumeSize() is not to be trusted (why?) it should be fixed. It has only single other user. It would be very confusing to see nextPhysSize logged here, followed by a different newSize sent to spm. Line 2296: nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB Line 2297: Line 2298: # NOTE: the intent of this check is to prevent faulty images to Line 2299: # trick qemu in requesting extremely large extensions (BZ#998443). -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
