Bala.FA has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
....................................................
Commit Message
Line 9: This patch adds a new verb glusterHostRemoveByUuid which
Line 10: retrives the host name based on uuid passed and uses it to
Line 11: remove the host.
Line 12:
Line 13: new verb: HostRemoveByUuid
You could say verb name correctly by GlusterHostRemoveByUuid
Line 14: return type: bool (success or failure)
Line 15: possible Exception: GlusterHostNotFoundException /
Line 16: GlusterHostRemoveFailedException.
Line 17:
....................................................
File vdsm/gluster/cli.py
Line 840: hostName = hostInfo['hostname']
Line 841: break
Line 842: else:
Line 843: raise ge.GlusterHostNotFoundException()
Line 844: return peerDetach(hostName, force)
Please move this logic to api.py as cli.py is one to one mapping with gluster
cli
Line 845:
Line 846:
Line 847: def _parsePeerStatus(tree, gHostName, gUuid, gStatus):
Line 848: hostList = [{'hostname': gHostName,
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
