Nir Soffer has posted comments on this change. Change subject: sampling: take storageDomains directly from storage subsys ......................................................................
Patch Set 2: (1 comment) Looks good, but we get do another little cleanup - sorry for not seeing this opportunity before. .................................................... File vdsm/API.py Line 1198: else: Line 1199: decStats['storageDomains'] = {} Line 1200: Line 1201: for var in decStats: Line 1202: stats[var] = utils.convertToStr(decStats[var]) Now we can move this cleanup into the if. Or maybe move all this to private method: def _getStorageDomainStats(self): if self._cif.irs is None: return {} get repo stats... convert values to strings... return it Can clean up a bit getStats. Line 1203: Line 1204: stats['memAvailable'] = self._memAvailable() / Mbytes Line 1205: stats['memCommitted'] = self._memCommitted() / Mbytes Line 1206: stats['memFree'] = self._memFree() / Mbytes -- To view, visit http://gerrit.ovirt.org/21334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a86b828fdf43d74bf4475d2c6632c4511519356 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches