Sent a patch that adds python-inotify as buildrequires (added Dan and Eyal as reviewers).
In general, anything that is a required by the main vdsm component should be a buildrequires and a requires and things which are only required for building should be only in the former category. I say this because we should make configure.ac check for all dependencies so that on general distributions the formal dependency checking should be done by configure (regardless of the fact that they should, as we do, list the dependencies in the packaging). ----- Original Message ----- > From: "Dan Kenigsberg" <dan...@redhat.com> > To: "Antoni Segura Puimedon" <asegu...@redhat.com> > Cc: "Eyal Edri" <ee...@redhat.com>, vdsm-patches@lists.fedorahosted.org > Sent: Monday, November 18, 2013 10:01:24 AM > Subject: Re: [oVirt Jenkins] vdsm_create_rpms - Build # 812 - Failure! > > On Mon, Nov 18, 2013 at 03:36:45AM -0500, Antoni Segura Puimedon wrote: > > Thanks Eyal! > > Toni, that's not enough - we should add a BuildRequires line for > something that our build scrtip requires. > _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
