Dan Kenigsberg has submitted this change and it was merged.

Change subject: Get rid of mutables(lists) as default parameters
......................................................................


Get rid of mutables(lists) as default parameters

In Python having a mutable as a default method parameter is
dangerous due to the fact that the mutables are created on
module creation rather than on method invokation. Thus, a
call to a method could pollute the environment for the next
call.

This patch cleans most instances of that happening.

Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5
Signed-off-by: Antoni S. Puimedon <asegu...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18356
Reviewed-by: Nir Soffer <nsof...@redhat.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
Reviewed-by: Petr Šebek <pse...@redhat.com>
Tested-by: Petr Šebek <pse...@redhat.com>
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/gluster/exception.py
M vdsm/storage/fileUtils.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/outOfProcess.py
M vdsm/vm.py
8 files changed, 12 insertions(+), 15 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Petr Šebek: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Better Saggi <bettersa...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to