Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
....................................................
File tests/functional/networkTests.py
Line 1581: {NETWORK_NAME: {'remove': True}},
Line 1582: {BONDING_NAME: {'remove': True}},
Line 1583: {'connectivityCheck': False})
Line 1584:
Line 1585: @permutations([[True], [False]])
we should not forget the @cleanupNet decorator.
And if you are changing this file, how about dropping the bridged permutation?
we should limit the number of tests due to their accumulating time.
Line 1586: @RequireVethMod
Line 1587: @ValidateRunningAsRoot
Line 1588: def testSetupNetworksAddDelDhcp(self, bridged):
Line 1589: with vethIf() as (left, right):
--
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas <pbe...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Petr Benas <pbe...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
