Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. ......................................................................
Patch Set 7: (2 comments) > Are all callers updated by this patch? Yes. # git grep refreshLV vdsm/storage/blockVolume.py:lvm.refreshLVs(self.sdUUID, (self.volUUID,)) vdsm/storage/lvm.py:def refreshLVs(vgName, lvNames): .................................................... Commit Message Line 8: Line 9: This change refactors the refreshLV method to allow multiple Line 10: volumes to be refreshed at once as possible with the activate Line 11: and deactive methods. Line 12: Done Line 13: Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d .................................................... File vdsm/storage/blockVolume.py Line 94: raise se.VolumeDoesNotExist(self.volUUID) # Fix me Line 95: volume.Volume.validate(self) Line 96: Line 97: def refreshVolume(self): Line 98: lvm.refreshLVs(self.sdUUID, self.volUUID) Done Line 99: Line 100: @classmethod Line 101: def getVSize(cls, sdobj, imgUUID, volUUID, bs=BLOCK_SIZE): Line 102: """ Returns size in block units. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches