Dan Kenigsberg has submitted this change and it was merged. Change subject: Allow setting just a single value in MoM policy ......................................................................
Allow setting just a single value in MoM policy This patch prevents a policy coruption that could have happened when the 01-parameters policy was updated with just a single value. If there were more values defined, the variables were lost and the policy ended up broken. This patch defines the variables in a file that is not touched by the setMOMPolicyParameters and uses (set name value) syntax in the generated policy part. It also remembers the old setting and puts all the values to the policy part when it is autogenerated. Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Signed-off-by: Martin Sivak <msi...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/21225 Reviewed-by: Amador Pahim <apa...@redhat.com> Reviewed-by: Doron Fediuck <dfedi...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M debian/vdsm.install M vdsm/Makefile.am A vdsm/mom.d/00-defines.policy D vdsm/mom.d/00-python.policy M vdsm/mom.d/01-parameters.policy M vdsm/momIF.py 6 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, but someone else must approve Amador Pahim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Amador Pahim <ama...@pahim.org> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
