Federico Simoncelli has posted comments on this change. Change subject: sp: [wip] receive domains map in connectStoragePool ......................................................................
Patch Set 1: (2 comments) .................................................... File vdsm/API.py Line 962: def connect(self, hostID, scsiKey, masterSdUUID, masterVersion, Line 963: domainsMap): Line 964: return self._irs.connectStoragePool( Line 965: self._UUID, hostID, scsiKey, masterSdUUID, masterVersion, Line 966: domainsMap) This was indeed a list in my first POC but then I realized that we can't change all at once. As we want incremental changes I wanted connectStoragePool to work as it is now without having to deal with missing "attached" (only) domains. I am sure there is some code on the engine side expecting the domain to be reported as "attached". So for now it's a map relying on the reconstructMaster code (both on vdsm and engine side) for creating and parsing the domains map (really simple and a noop for me). Line 967: Line 968: def connectStorageServer(self, domainType, connectionParams): Line 969: return self._irs.connectStorageServer(domainType, self._UUID, Line 970: connectionParams) .................................................... File vdsm/storage/sp.py Line 1980: Line 1981: ### Deprecated Methods Section End ### Line 1982: Line 1983: Line 1984: class StoragePoolLegacy(StoragePoolBase): You're right. I couldn't find a good name though. But as a general class design is this ok with you? Line 1985: Line 1986: def __init__(self, spUUID, domainMonitor, taskManager): Line 1987: super(StoragePool, self) \ Line 1988: .__init__(spUUID, domainMonitor, taskManager) -- To view, visit http://gerrit.ovirt.org/21427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
