Federico Simoncelli has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. ......................................................................
Patch Set 10: Code-Review+2 (1 comment) No need to block on my minor comments if you don't want to. .................................................... File vdsm/storage/lvm.py Line 1149: _lvminfo._lvs.pop((vg, oldlv), None) Line 1150: _lvminfo._reloadlvs(vg, newlv) Line 1151: Line 1152: Line 1153: def refreshLVs(vgName, lvNames): I heard some of your ideas about function names, feel free to start using them whenever you want. With regard to lvName, what's your opinion on _normalizeargs? (or in general using *args?). I have mixed feelings, so go ahead and use whatever you prefer (or think is superior). Line 1154: # If the logical volumes are active, reload their metadata. Line 1155: cmd = ['lvchange', '--refresh'] Line 1156: cmd.extend("%s/%s" % (vgName, lv) for lv in lvNames) Line 1157: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, ))) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches