Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: improvements from using Link devices
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
I like the move towards using Link objects, but please limit the patch to one
topic.
....................................................
File lib/vdsm/netinfo.py
Line 93: return res
Line 94:
Line 95:
Line 96: def vlans():
Line 97: return [link.name for link in getLinks() if link.isVLAN() and not
why was that change? keeping "not" near its operand is nicer.
Line 98: link.isHidden()]
Line 99:
Line 100:
Line 101: def bridges():
Line 533:
Line 534: for net, netAttr in networks().iteritems():
Line 535: try:
Line 536: d['networks'][net] = _getNetInfo(netAttr.get('iface',
net),
Line 537: netAttr['bridged'],
this patch is too spread even without whitespace changes like this...
Line 538: gateways, ipv6routes,
Line 539:
netAttr.get('qosInbound'),
Line 540:
netAttr.get('qosOutbound'))
Line 541: except KeyError:
....................................................
File tests/netinfoTests.py
Line 149: '35: fake: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu
1500 qdisc '
Line 150: 'pfifo_fast state UP mode DEFAULT group default qlen
1000\\ '
Line 151: ' link/ether ff:aa:f1:da:bb:e7 brd
ff:ff:ff:ff:ff:ff '
Line 152: 'promiscuity 0 \\ dummy ',
Line 153: '419: jbond:
<BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu '
I baffled whether the unit test changes truly necessary in this patch.
Line 154: '1500 qdisc noqueue state UP mode DEFAULT group
default \ '
Line 155: 'link/ether 66:de:f1:da:aa:e7 brd ff:ff:ff:ff:ff:ff '
Line 156: 'promiscuity 1 \ bond')
Line 157: return [ipwrapper.Link.fromText(line) for line in lines]
--
To view, visit http://gerrit.ovirt.org/21408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
