Ayal Baron has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 ......................................................................
Patch Set 4: (1 comment) .................................................... File vdsm/supervdsmServer Line 43: Line 44: from storage import fuser Line 45: from multiprocessing import Pipe, Process Line 46: try: Line 47: from gluster import listPublicFunctions s/listPublicFunction/listGlusterPublicFunctions/ When used it is difficult to understand that this is gluster related Line 48: _glusterEnabled = True Line 49: except ImportError: Line 50: _glusterEnabled = False Line 51: -- To view, visit http://gerrit.ovirt.org/21477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
