Martin Betak has posted comments on this change.
Change subject: vdsm: Accents in the vm name break the migration
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/vm.py
Line 4876: self._pathsPreparedEvent.wait(prepareTimeout)
Line 4877: if not self._pathsPreparedEvent.isSet():
Line 4878: self.log.debug('Timeout while waiting for path
preparation')
Line 4879: return False
Line 4880: srcDomXML = self.conf.pop('_srcDomXML').encode('utf-8')
Dan, minidom.parseString requires correctly encoded byte string (str) not an
unicode object.
While XMLDesc(0) returns already properly encoded str object that can be passed
directly to minidom.parseString, on the destination we get an unicode object
since xmlrpclib uses utf-8 by default.
encode('utf-8') serves essensialy as a type conversion from 'unicode' to 'str'.
Line 4881: self._updateDevicesDomxmlCache(srcDomXML)
Line 4882:
Line 4883: for dev in self._customDevices():
Line 4884: hooks.before_device_migrate_destination(
--
To view, visit http://gerrit.ovirt.org/19684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db5ea4f0745ef42633e3d265bcf40fb4733b2ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
