Hello Bala.FA, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21538
to review the following change.
Change subject: gluster: correct parameter for creating hookpath in verb
hookAdd.
......................................................................
gluster: correct parameter for creating hookpath in verb hookAdd.
parameter hookLevel must be in lower case for creating correct
path for hook. so that parameter is changed to lower case.
Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
https://bugzilla.redhat.com/show_bug.cgi?id=1028972
Signed-off-by: ndarshan <dnara...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21017
Reviewed-by: Aravinda VK <avish...@redhat.com>
Reviewed-by: Bala.FA <barum...@redhat.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm/gluster/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/21538/1
diff --git a/vdsm/gluster/hooks.py b/vdsm/gluster/hooks.py
index 914d09d..4f1c14d 100644
--- a/vdsm/gluster/hooks.py
+++ b/vdsm/gluster/hooks.py
@@ -244,7 +244,7 @@
@makePublic
def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum,
enable=False):
- hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
+ hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel.lower())
try:
os.makedirs(hookPath)
if selinux.is_selinux_enabled():
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
