Antoni Segura Puimedon has posted comments on this change.
Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts
......................................................................
Patch Set 2: Verified+1
Manual verification:
In [1]: from vdsm import netinfo
In [2]: netinfo.bondOpts('bond777')
Out[2]:
{'active_slave': [],
'ad_actor_key': [],
'ad_aggregator': [],
'ad_num_ports': [],
'ad_partner_key': [],
'ad_partner_mac': [],
'ad_select': ['stable', '0'],
'all_slaves_active': ['0'],
'arp_all_targets': ['any', '0'],
'arp_interval': ['0'],
'arp_ip_target': [],
'arp_validate': ['none', '0'],
'downdelay': ['0'],
'fail_over_mac': ['none', '0'],
'lacp_rate': ['slow', '0'],
'lp_interval': ['1'],
'mii_status': ['up'],
'miimon': ['100'],
'min_links': ['0'],
'mode': ['broadcast', '3'],
'num_grat_arp': ['1'],
'num_unsol_na': ['1'],
'primary': [],
'primary_reselect': ['always', '0'],
'queue_id': ['dummy_888:0', 'dummy_999:0'],
'resend_igmp': ['1'],
'slaves': ['dummy_888', 'dummy_999'],
'updelay': ['0'],
'use_carrier': ['1'],
'xmit_hash_policy': ['layer2', '0']}
In [3]: netinfo.speed('bond777')
Out[3]: 0
In [4]: netinfo.bondOpts('bond0')
Out[4]:
{'active_slave': [],
'ad_actor_key': ['0'],
'ad_aggregator': ['0'],
'ad_num_ports': ['0'],
'ad_partner_key': ['0'],
'ad_partner_mac': [],
'ad_select': ['stable', '0'],
'all_slaves_active': ['0'],
'arp_all_targets': ['any', '0'],
'arp_interval': ['0'],
'arp_ip_target': [],
'arp_validate': ['none', '0'],
'downdelay': ['0'],
'fail_over_mac': ['none', '0'],
'lacp_rate': ['slow', '0'],
'lp_interval': ['1'],
'mii_status': ['down'],
'miimon': ['9'],
'min_links': ['0'],
'mode': ['802.3ad', '4'],
'num_grat_arp': ['1'],
'num_unsol_na': ['1'],
'primary': [],
'primary_reselect': ['always', '0'],
'queue_id': [],
'resend_igmp': ['1'],
'slaves': [],
'updelay': ['0'],
'use_carrier': ['1'],
'xmit_hash_policy': ['layer2', '0']}
In [5]: netinfo.speed('bond0')
Out[5]: 0
--
To view, visit http://gerrit.ovirt.org/21554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
