Assaf Muller has posted comments on this change.

Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
......................................................................


Patch Set 14:

(3 comments)

....................................................
File lib/vdsm/utils.py
Line 103:     return stat.S_ISBLK(os.stat(path).st_mode)
Line 104: 
Line 105: 
Line 106: def touchFile(filePath, ignoreExceptions=False):
Line 107:     """
Done
Line 108:     Subset of POSIX touch functionality
Line 109:     :param filePath: The file to touch
Line 110:     :param ignoreExceptions: Should file handling exceptions be 
ignored?
Line 111:     """


....................................................
File vdsm/logger.conf.in
Line 1: [loggers]
Line 2: keys=root,vds,Storage,metadata
I need to get my eyes checked... Thanks.
Line 3: 
Line 4: [handlers]
Line 5: keys=console,syslog,logfile,metadata
Line 6: 


Line 1: [loggers]
Line 2: keys=root,vds,Storage,metadata
Line 3: 
Line 4: [handlers]
Line 5: keys=console,syslog,logfile,metadata
Done
Line 6: 
Line 7: [formatters]
Line 8: keys=long,simple,none,sysform
Line 9: 


-- 
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to