Nir Soffer has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
(4 comments)
....................................................
Commit Message
Line 10: logged as info:
Line 11: 1._findDomain - looking for unfetched domain
Line 12: 2._findUnfetchedDomain - looking for domain
Line 13:
Line 14: Also an error is raised in the process, now logged as info.
We can see what was changed in the code. Can you explain why did make those
changes?
Line 15:
Line 16: Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Line 17: Signed-off-by: Vered Volansky <vvola...@redhat.com>
....................................................
File vdsm/storage/sdc.py
Line 133: def _findDomain(self, sdUUID):
Line 134: try:
Line 135: findMethod = self.knownSDs[sdUUID]
Line 136: except KeyError:
Line 137: self.log.info("looking for unfetched domain %s", sdUUID)
Looks like debug message to me.
Line 138: findMethod = self._findUnfetchedDomain
Line 139:
Line 140: try:
Line 141: dom = findMethod(sdUUID)
Line 139:
Line 140: try:
Line 141: dom = findMethod(sdUUID)
Line 142: except se.StorageDomainDoesNotExist:
Line 143: self.log.info("domain %s not found", sdUUID,
exc_info=True)
Is this a real error or normal condition?
Line 144: raise
Line 145: else:
Line 146: return dom
Line 147:
Line 150: import glusterSD
Line 151: import localFsSD
Line 152: import nfsSD
Line 153:
Line 154: self.log.info("looking for domain %s", sdUUID)
Looks like debug message to me.
Line 155:
Line 156: # The order is somewhat important, it's ordered
Line 157: # by how quickly get can find the domain. For instance
Line 158: # if an nfs mount is unavailable we will get stuck
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
