Dan Kenigsberg has posted comments on this change.
Change subject: utils: Introduce CallbackChain
......................................................................
Patch Set 12:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 997: self.callbacks = deque(callbacks)
Line 998:
Line 999: def run(self):
Line 1000: """Invokes serially the callback objects until any reports
success."""
Line 1001: self.log.debug("Starting callback chain.")
I've learned from experience that each Thread.run() must include a try-except
block, logging silly (or smart) errors.
Line 1002: while self.callbacks:
Line 1003: callback = self.callbacks.popleft()
Line 1004: if callback():
Line 1005: self.log.debug("Succeeded after invoking " +
--
To view, visit http://gerrit.ovirt.org/19228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
