Lee Yarwood has posted comments on this change. Change subject: Introduce a maximum time limit a migration may take ......................................................................
Patch Set 1: (1 comment) After discussing this issue with Vinzenz and Tomas at length today I've suggested that for now we base the overall timeout value on a simple calculation using a percentage of the migration bandwidth. In the longer term I really think we should move the logic for both calculating this timeout and monitoring migration progression to the engine. I've created the following RFEs requesting this : [RFE] Allow migration configuration values to be set per VM from engine https://bugzilla.redhat.com/show_bug.cgi?id=1034871 [RFE] Engine should apply a sensible overall timeout to the live migration of guests. https://bugzilla.redhat.com/show_bug.cgi?id=1034893 .................................................... File lib/vdsm/config.py.in Line 54: 'Maximum time the destination waits since migration is stalled. ' Line 55: 'Please note, that this is not overall migration timeout. ' Line 56: 'Source waits twice as long (to avoid races).'), Line 57: Line 58: ('migration_max_time', '21600', I've suggested that this value is based on the time taken to transfer the memory of a guest given a certain percentage of migration bandwidth. For example for a 4GB guest allowing for 50% of the default 32MiB/s migration bandwidth we would set the timeout to 281. Line 59: 'The maximum time in seconds a migration may take before the ' Line 60: 'migration will be aborted.'), Line 61: Line 62: ('migration_listener_timeout', '30', -- To view, visit http://gerrit.ovirt.org/21708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Tomáš Došek <tdo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
