Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Log exceptions in domain monitor thread
......................................................................
Patch Set 2:
After discussion with Federico, the plan is to add a @traceback decorator,
logging a traceback for any error in the decorated function.
We will use this decorator on any thread main entry point to so we will never
have a silent thread death again.
We will use this decorator on a looping function so after a failure in a status
thread check routine, we continue to loop without writing the explicit
try-except logic everywhere.
@logged(DomainMonitorThread, "Unhandled exception")
def _monitorLoop(self):
while not self.stopEvent.isSet():
self._monitorDomain()
self.stopEvent.wait(self.interval)
@logged("DomainMonitorThread", "Domain monitoring failed")
def _montiorDomain(self):
...
--
To view, visit http://gerrit.ovirt.org/21487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
