Vinzenz Feenstra has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
......................................................................
Patch Set 2:
(2 comments)
....................................................
File vdsm/vm.py
Line 3309: if self.isMigrating():
Line 3310: return errCode['migInProgress']
Line 3311:
Line 3312: self.log.debug("Setting number of cpus to : %s" %
Line 3313: params.get['numberOfCpus'])
self.log.debug("Setting number of cpus to : %s", params.get['numberOfCpus'])
without the % -> we let the logger decide to apply the formatting or not
(depends on the log level)
Line 3314:
Line 3315: try:
Line 3316: self._dom.setVcpu(params.get('numberOfCpus'))
Line 3317: except libvirt.libvirtError as e:
....................................................
File vdsm_api/Bridge.py
Line 339: 'Volume_getInfo': {'ret': 'info'},
Line 340: 'Volume_getPath': {'ret': 'path'},
Line 341: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 342: 'Host_getAllTasks': {'ret': 'tasks'},
Line 343: 'VM_setNumberOfCpus': {'ret': 'vmList'},
please put it in the VM_ section, the entries are sorted
Line 344: }
Line 345:
Line 346:
Line 347: def fieldClone(oldName, newName, obj):
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
