Dan Kenigsberg has posted comments on this change. Change subject: Made ipwrapper.py:Route class more robust ......................................................................
Patch Set 2: Code-Review+2 (2 comments) .................................................... Commit Message Line 6: Line 7: Made ipwrapper.py:Route class more robust Line 8: Line 9: Route can now parse routes of the form: Line 10: 'local 127.0.0.1 dev lo src 127.0.0.1' You also improve Route's interface to better conform with ip-route nomenclature. (src/via) Line 11: Line 12: Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab .................................................... File lib/vdsm/ipwrapper.py Line 267: params = route[2:] Line 268: else: Line 269: params = route[1:] Line 270: Line 271: data = dict(params[i:i + 2] for i in range(0, len(params), 2)) pairwise's calling! (in another patch) Line 272: data['network'] = '0.0.0.0/0' if network == 'default' else network Line 273: return data Line 274: Line 275: @classmethod -- To view, visit http://gerrit.ovirt.org/21788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
