Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
......................................................................
Patch Set 6:
(1 comment)
....................................................
File vdsm/gluster/hostname.py.in
Line 20:
Line 21: from vdsm import utils
Line 22:
Line 23: _hostNameCommandPath = utils.CommandPath("hostname",
Line 24: "@HOSTNAME_PATH@",
Because on EL6 or < F21 it's /bin/hostname. Even others distros can be
different path, so doing it dynamic (according with the build/target system) is
more safe.
Line 25: )
Line 26:
Line 27:
Line 28: class HostNameException(Exception):
--
To view, visit http://gerrit.ovirt.org/21194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Cole Robinson <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
