Martin Sivák has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
......................................................................
Patch Set 1:
Athough I agree with Dan's reasoning, there is no trace of Running in
VALID_STATES or the documented API:
VALID_STATES = ('Down', 'Migration Destination', 'Migration Source',
'Paused', 'Powering down', 'RebootInProgress',
'Restoring state', 'Saving State',
'Up', 'WaitForLaunch')
##
# @VmStatus:
#
# An enumeration of possible virtual machine statuses.
#
# @Down: The VM is powered off
#
# @Migration Destination: The VM is migrating to this host
#
# @Migration Source: The VM is migrating away from this host
#
# @Paused: The VM is paused
#
# @Powering down: A shutdown command has been sent to the VM
#
# @RebootInProgress: The VM is currently rebooting
#
# @Restoring state: The VM is waking from hibernation
#
# @Saving State: The VM is preparing for hibernation
#
# @Up: The VM is running
#
# @WaitForLaunch: The VM is being created
#
# Since: 4.10.0
##
{'enum': 'VmStatus',
'data': ['Down', 'Migration Destination', 'Migration Source', 'Paused',
'Powering down', 'RebootInProgress', 'Restoring state',
'Saving State', 'Up', 'WaitForLaunch']}
So we either fix it in the documentation (and document the state as deprecated)
or in the code. Otherwise someone else will try hit it when trying to check for
the "Up" state.
--
To view, visit http://gerrit.ovirt.org/21766
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
