Antoni Segura Puimedon has posted comments on this change. Change subject: Add iproute2 configurator ......................................................................
Patch Set 20: Verified-1 (1 comment) Fails for when configurator is ifcgs (see comment). .................................................... File vdsm/netconf/ifcfg.py Line 48: super(Ifcfg, self).__init__(ConfigWriter(), inRollback) Line 49: Line 50: def begin(self): Line 51: if self.configApplier is None: Line 52: self.configApplier = ConfigWriter() Since you removed the unified persistence attribute, this will raise an AttributeError. Line 53: if self.unifiedPersistence and self.runningConfig is None: Line 54: self.runningConfig = RunningConfig() Line 55: Line 56: def rollback(self): -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
