Ayal Baron has posted comments on this change. Change subject: sp: remove the getFormat method ......................................................................
Patch Set 3: "Are you saying that there's a logical difference between getVersion and getFormat? Or you're saying that we can get rid of getVersion and keep getFormat (handling the str/int differences). I don't understand why we need both, are they the same value just by accident?" The original 'getVersion' was a misnomer as it is a format (store in LV or store in VG tags or any other way). One is not superior to the other, just different. I'm fine with getting rid of getVersion, but make sure there will be no BC issues there. -- To view, visit http://gerrit.ovirt.org/21785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb292ef57f94e1fea67f3111e5f414cc41c346a9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
