Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
......................................................................
Patch Set 14:
(2 comments)
....................................................
File vdsm/caps.py
Line 214: return ''
Line 215:
Line 216:
Line 217: def _getRngSources():
Line 218: sources = []
it could be nicer to have
return [source for (source, path) in RNG_SOURCES.iteritems()
if os.path.exists(path)]
(non blocker, just quicker, nicer and more pythonic).
Line 219: for source, path in RNG_SOURCES.items():
Line 220: if os.path.exists(path):
Line 221: sources.append(source)
Line 222:
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2693: #
Line 2694: # Since: 4.12.0
Line 2695: ##
Line 2696: {'enum': 'VmRngDeviceSource',
Line 2697: 'data': ['random', 'hwrng']}
it's going to be new in v4.14.0
Line 2698:
Line 2699: ##
Line 2700: # @VmRngDeviceSpecParams:
Line 2701: #
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Better Saggi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
