Dan Kenigsberg has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
....................................................
File lib/vdsm/netconfpersistence.py
Line 55:
Line 56: def diffFrom(self, other):
Line 57: """Returns a diff Config that shows the what should be changed
for
Line 58: going from other to self."""
Line 59: diff = Config('')
this is a bit odd... Does it assume that we have no garbage under /nets/, and
that we would never ever have a bug where supervdsm ends up writing persistence
into there?
I'd prefer an explicit backend-less Config() object (even if implemented by
passing an empty tempdir)
Line 60: diff.networks = self._confDictDiff(self.networks,
other.networks)
Line 61: diff.bonds = self._confDictDiff(self.bonds, other.bonds)
Line 62: return diff
Line 63:
--
To view, visit http://gerrit.ovirt.org/21728
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a3be5610492fd3cb27d49703e04a84cfad57d1
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
