Sergey Gotliv has posted comments on this change. Change subject: vdsm: Add an exception for wrong master version. ......................................................................
Patch Set 3: (1 comment) .................................................... File vdsm/storage/storage_exception.py Line 609: code = 330 Line 610: message = "Cannot get file stats" Line 611: Line 612: Line 613: class StoragePoolWrongVersion(StorageException): We are working to remove pool in 3.4, I am wondering if its really necessary to add new pool related exception at this phase. I am fine with the code once you verified that the current engine without any additional change will survive that exception. Line 614: def __init__(self, spUUID, sdUUID): Line 615: self.value = "SD=%s, pool=%s" % (sdUUID, spUUID) Line 616: code = 331 Line 617: message = "Wrong Master version" -- To view, visit http://gerrit.ovirt.org/21175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches