Humble Devassy Chirammal has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
....................................................
File vdsm_hooks/extnet/README
Line 15: Usage:
Line 16: Define a vNIC profile and set one of its custom properites to extnet
with
Line 17: the value of the name of a libvirt network that is managed outside of
oVirt.
Line 18: Then, attach the defined profile to a vNIC. When the VM is run, the
relevant
Line 19: vNIC would be attached to the forced external network network instead
of the
above line is incomplete...
....................................................
File vdsm_hooks/extnet/extnet_vnic.py
Line 21:
Line 22: def replaceSource(interface, newnet):
Line 23: source, = interface.getElementsByTagName('source')
Line 24: source.removeAttribute('bridge')
Line 25: source.setAttribute('network', newnet)
If it is openvswitch bridge , is n't it, we have to 'append' below line to the
interface definition ?
<virtualport type='openvswitch'/>
Line 26: interface.setAttribute('type', 'network')
Line 27:
Line 28:
Line 29: def main():
--
To view, visit http://gerrit.ovirt.org/22124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bc74a9ac4a6eb88d089baa86918275c61f5190
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchir...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
