Hello Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22214
to review the following change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
......................................................................
domainMonitor: Log unhandled exceptions in domain monitor thread
DomainMonitorThread does not handle exceptions in the thread main
function, making it harder to modify the code or understanding
unexpected failures in the field.
The patch log unhandled exceptions so it will never die silently.
Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb
Relates-To: https://bugzilla.redhat.com/1034741
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/21487
Reviewed-by: Federico Simoncelli <[email protected]>
---
M vdsm/storage/domainMonitor.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/22214/1
diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index ac01e8b..09952b8 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -24,6 +24,7 @@
import logging
import misc
+from vdsm import utils
from vdsm.config import config
from sdc import sdCache
@@ -152,6 +153,7 @@
def getStatus(self):
return self.status.copy()
+ @utils.traceback(on=log.name)
def _monitorLoop(self):
self.log.debug("Starting domain monitor for %s", self.sdUUID)
--
To view, visit http://gerrit.ovirt.org/22214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
