Dan Kenigsberg has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result ......................................................................
Patch Set 3: (1 comment) .................................................... File lib/vdsm/tool/configurator.py Line 138: Line 139: def isconfigured(self, *args): Line 140: """ Line 141: True if sanlock service requires a restart to reload the relevant Line 142: supplementary groups. The docstring does not say something as simple as that. Maybe you can improv the English. Line 143: """ Line 144: ret = False Line 145: proc_status_group_prefix = "Groups:\t" Line 146: try: -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
