Francesco Romani has posted comments on this change. Change subject: mkimage: create files with explicit permissions ......................................................................
Patch Set 1: (3 comments) .................................................... Commit Message Line 33: Line 34: However, we still need to change to behaviour of `genisoimage` because Line 35: it now uses the `-r` option to smartly fix permissions and POSIX Line 36: attributes in a meaningful way. Now we need to preserve verbatim the Line 37: attributes. The biggest (only?) change wrt to this is genisoimage "with respect to". Will expand in the next revision. Line 38: no longer automatically fixes uid/gid of the content of the ISO image Line 39: to 0/0, and preserves the creator process values. Line 40: Line 41: Change-Id: I880143d80c863820aa3a063a6ad8e12fad7e7c42 .................................................... File tests/mkimageTests.py Line 118: filepath = os.path.join(self.workdir, filename) Line 119: self._check_permissions(filepath, Line 120: ((stat.S_IROTH, False), Line 121: (stat.S_IWOTH, False), Line 122: (stat.S_IXOTH, False))) OK, will add. Line 123: with open(filepath, "r") as fd: Line 124: content = fd.read() Line 125: self.assertEqual(content, self.expected_results[filename]) Line 126: .................................................... File vdsm/mkimage.py Line 34: Line 35: _P_PAYLOAD_IMAGES = os.path.join(P_VDSM_RUN, 'payload') Line 36: Line 37: Line 38: def _openFile(filename, mode, perms=0o644): It's mostly just for an habit of mine. I will remove it. Line 39: ''' Line 40: opens a filename allowing to specify the unix permissions Line 41: right from the start, to avoid world-readable files Line 42: with sensitive informations. -- To view, visit http://gerrit.ovirt.org/21965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I880143d80c863820aa3a063a6ad8e12fad7e7c42 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
