Antoni Segura Puimedon has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
......................................................................
Patch Set 9: Verified+1
Passed the unit tests and manual tests consisting of:
- Creating a non QoSed 'foo' network and seeing that no QoS info is returned in
the caps.
- Creating a QoSed network 'bar' with only inbound average set and seeing that
only inbound average is returned in caps:
networks = {'bar': {'addr': '',
'bridged': True,
'cfg': {'DEFROUTE': 'no',
'DELAY': '0',
'DEVICE': 'bar',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'TYPE': 'Bridge'},
'gateway': '',
'iface': 'bar',
'ipv6addrs': [],
'ipv6gateway': '::',
'mtu': '1500',
'netmask': '',
'ports': ['eth1'],
'qosInbound': {'average': 1600},
'stp': 'off'},
'foo': {'addr': '',
'bridged': True,
'cfg': {'DEFROUTE': 'no',
'DELAY': '0',
'DEVICE': 'foo',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'TYPE': 'Bridge'},
'gateway': '',
'iface': 'foo',
'ipv6addrs': [],
'ipv6gateway': '::',
'mtu': '1500',
'netmask': '',
'ports': ['eth2'],
'stp': 'off'}}
--
To view, visit http://gerrit.ovirt.org/22018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d2bc8310fed2ad3c0a748cdf1cfd2cf050aa2f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
