Yaniv Bronhaim has uploaded a new change for review. Change subject: Don't reconfigure if configured when force is set ......................................................................
Don't reconfigure if configured when force is set There is no need for that. We kept the old --force way which overrided the old configuration. There is no reason for that, and with the new design of configuration modules this cause regressions as it runs also sanlock configure although its configured and fails to stop to service. Change-Id: I6d5a652b300c9d8165f661840c49a441532e84b1 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035847 --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/22309/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 869d774..43debe1 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -191,7 +191,7 @@ raise RuntimeError( "Configuration of %s is invalid" % c.getName() ) - if args.force or not c.isconfigured(): + if not c.isconfigured(): configurer_to_trigger.append(c) services = [] -- To view, visit http://gerrit.ovirt.org/22309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d5a652b300c9d8165f661840c49a441532e84b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
