Assaf Muller has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/netconf/ifcfg.py
Line 612:
Line 613: def addNic(self, nic, **opts):
Line 614: """ Create ifcfg-* file with proper fields for NIC """
Line 615: _netinfo = netinfo.NetInfo()
Line 616: conf = ''
What if we add a nic, then the admin decides to enable NM (Say, when a new
Fedora is released). Do we care about that?
Line 617: if _hwaddr_required():
Line 618: hwaddr = (_netinfo.nics[nic.name].get('permhwaddr') or
Line 619: _netinfo.nics[nic.name]['hwaddr'])
Line 620:
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
