Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Add config option for network configurator
......................................................................
Patch Set 10:
(3 comments)
....................................................
File lib/vdsm/config.py.in
Line 41: ('fake_nics', 'dummy_*,veth_*',
Line 42: 'Comma-separated list of fnmatch-patterns for dummy hosts
nics to '
Line 43: 'be shown to vdsm.'),
Line 44:
Line 45: ('configurator', 'ifcfg',
we should qualify this, and the already existing 'persistence' configurable,
with a net_ prefix.
Line 46: 'Whether to use "ifcfg" or "iproute2" to configure
networks.'),
Line 47:
Line 48: ('persistence', 'ifcfg',
Line 49: 'Whether to use "ifcfg" or "unified" persistence for
networks.'),
....................................................
File vdsm/configNetwork.py
Line 50: configurator = config.get('vars', 'configurator')
Line 51: if configurator == 'iproute2':
Line 52: from netconf.iproute2 import Iproute2
Line 53: return Iproute2
Line 54: else:
Why isn't this a plain elif?
Line 55: if configurator != 'ifcfg':
Line 56: logging.warn('Invalid config for network configruator: %s.
'
Line 57: 'Use ifcfg instead.', configurator)
Line 58: from netconf.ifcfg import Ifcfg
Line 57: 'Use ifcfg instead.', configurator)
Line 58: from netconf.ifcfg import Ifcfg
Line 59: return Ifcfg
Line 60:
Line 61: configuratorClass = _getConfiguratorClass()
It's a class variable, but it's still a class, so "ConfiguratorClass" is more
customary.
Line 62:
Line 63:
Line 64: def objectivizeNetwork(bridge=None, vlan=None, bonding=None,
Line 65: bondingOptions=None, nics=None, mtu=None,
ipaddr=None,
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I426a38f229131ce6d32568387be7a809b09ae0c1
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
