Dan Kenigsberg has submitted this change and it was merged. Change subject: Add iproute2 configurator ......................................................................
Add iproute2 configurator This patch adds a new host network configurator based on iproute2. We could just reuse the ifcfg's configurator totally and add a new ConfigWriter based on iproute2. But it turns out this approach is not very suitable to the iprtoute2 model. The ifcfg configurator depends on the behavior of ifup/ifdown, so it imposes some unnecessary restriction on the new ConfigWriter. So this patch chooses to add a new configurator and reuse some code of ifcfg configurator. In future, we could move those common code to a base class after refactoring ifcfg configurator. This patch dosen't include the support for dhcp and ipv6, which will be added in following patches. Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Signed-off-by: Mark Wu <wu...@linux.vnet.ibm.com> Reviewed-on: http://gerrit.ovirt.org/15301 Reviewed-by: Antoni Segura Puimedon <asegu...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/define.py M vdsm/netconf/__init__.py M vdsm/netconf/ifcfg.py M vdsm/netconf/iproute2.py M vdsm/neterrors.py 5 files changed, 247 insertions(+), 8 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
