Dan Kenigsberg has posted comments on this change. Change subject: sriov: stop virtual functions from being reported as nics ......................................................................
Patch Set 6: Code-Review-1 (1 comment) .................................................... File lib/vdsm/ipwrapper.py Line 40: '/sbin/ethtool', # EL6, ubuntu and Debian Line 41: '/usr/bin/ethtool', # Arch Line 42: ) Line 43: Line 44: SRIOV_POOL = 'direct-pool' Having vdsm depend on a hook-specific construct like this is the pretty wrong. Can we find a smarter way to filter non-host VFs? Line 45: Line 46: Line 47: def _isValid(ip, verifier): Line 48: try: -- To view, visit http://gerrit.ovirt.org/22559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbb345ee22b7b108f1fd58765bd371339b82198f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
