Nir Soffer has posted comments on this change.
Change subject: vm: janitorial: factorize key deletion in Vm.conf
......................................................................
Patch Set 2:
I think this is the wrong way. We access self.conf is a thread unsafe way all
over vm.py. Fixing two places where we delete keys is not enough.
What we should do is remove 'recover' and 'pauseCode' from self.conf and make
them Vm attributes.
For example:
# instead of 'recover' in self.conf
if self.recovering:
# Instead of with self._confLock: self.conf.pop('recover', None)
self.recovering = False
If we do that, we don't need the new method suggested by this patch. And we
cannot have to argue about "should we explode if there is no recover key here".
--
To view, visit http://gerrit.ovirt.org/22556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5a3da3fea0346f5f75c2f9d60c995aaf7214c6d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
