Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
......................................................................
Patch Set 15: Code-Review-1
(1 comment)
....................................................
File lib/vdsm/ipwrapper.py
Line 619: def __iter__(self):
Line 620: try:
Line 621: self.proc.blocking = True
Line 622: except AttributeError:
Line 623: raise MonitorError('The monitor has not run yet')
argh, my text was not clear. the "race" there is only "apparent", it's not for
real. If someone wants to read events without making sure that the
monitor.start() finished, he should explode.
So let's make this patch a bit better by moving blocking = True to where it
belongs.
Line 624: for line in self.proc.stdout:
Line 625: yield self._parseLine(line)
Line 626:
Line 627: def start(self):
--
To view, visit http://gerrit.ovirt.org/21430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ca850fc324a5b4c0268541fd4d4d062706a159
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
