Assaf Muller has posted comments on this change. Change subject: netconf: enable multiple gateways for iproute2 configurator ......................................................................
Patch Set 7: Code-Review-1 A few updates: * Once we rebase this patch we can theoretically remove the To-Do item, as netinfo.getBootProtocol has since been enhanced to support both the ifcfg and unified persistence models * It's clear from the changes made in this patch that the current design for the SourceRoute classes doesn't *actually* support multiple configurators... Passing a 'byIproute2' flag doesn't count :) A new design needs to be thought up that properly supports multi-configurators * There's verification work to be done -- To view, visit http://gerrit.ovirt.org/16276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
