Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: log unhandled exceptions ......................................................................
Patch Set 2: (1 comment) .................................................... File vdsm/sourceRouteThread.py Line 50: # Subscribe to pyinotify event Line 51: watchManager = pyinotify.WatchManager() Line 52: handler = DHClientEventHandler() Line 53: notifier = pyinotify.Notifier(watchManager, handler) Line 54: watchManager.add_watch(SOURCE_ROUTES_FOLDER, pyinotify.IN_CLOSE_WRITE) I afraid your test was incorrect because we never start subscribeToInotifyLoop in a thread; it runs in the main thread :-) This issue is resolved by gerrit.ovirt.org/#/c/22718/ Can you repeat the test with 22718? Line 55: Line 56: # Run once manually in case dhclient operated while supervdsm was down Line 57: # Run sorted so that if multiple files exist for an interface, we'll Line 58: # execute them alphabetically and thus according to their time stamp -- To view, visit http://gerrit.ovirt.org/22670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23eaf7a41c8decaea64a392d58ef6ba31f24d795 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
