Ayal Baron has posted comments on this change.

Change subject: hsm: Do not hide errors when checking device visibility
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 2005:             try:
Line 2006:                 res = (os.stat('/dev/mapper/' + guid).st_mode &
Line 2007:                        stat.S_IRUSR != 0)
Line 2008:             except OSError as e:
Line 2009:                 if e.errno != errno.NOENT:
s/NOENT/ENOENT/
Line 2010:                     raise
Line 2011:                 res = False
Line 2012:             return res
Line 2013: 


-- 
To view, visit http://gerrit.ovirt.org/21211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to